New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added currently supported regions for GCP functions #5601

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@welkie
Copy link

welkie commented Dec 15, 2018

What did you implement:

Added documentation in GCP section.

I ran into an issue while trying out Serverless with GCP. I noticed that it set the region to us-central1 when I deployed from the template. I wanted to use the region closest to me instead, which is their Canadian region. I tried different ways to change the region but nothing worked, and I later realized GCP only has Google Cloud Functions support in 4 regions right now.

I think if this were made clearer upfront, I wouldn't have spent time on that. I decided to add a note to the entry page in the docs for GCP if the maintainers are interested in this. This is my first PR for this repo, and I'm not familiar with it, so if this information isn't appropriate for the docs or if there's a better way to convey this information, I welcome feedback/changes.

How did you implement it:

Added documentation to docs/providers/google/guide/README.md.

How can we verify it:

Examine file docs/providers/google/guide/README.md.

Todos:

  • [n/a] Write tests
  • Write documentation
  • [n/a] Fix linting errors
  • [n/a] Make sure code coverage hasn't dropped
  • [n/a] Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens

pmuens approved these changes Dec 20, 2018

Copy link
Member

pmuens left a comment

LGTM! Thanks for updating @welkie 👍

@pmuens pmuens merged commit 059ec69 into serverless:master Dec 20, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.777%
Details

dschep added a commit that referenced this pull request Jan 9, 2019

v1.36.0 release!
 - [Log AWS SDK calls in debug mode](#5604)
 - [Added currently supported regions for GCP functions](#5601)
 - [Update Cloudflare Templates](#5620)
 - [AWS: Validate rate/cron syntax before Deploy](#5635)
 - [Fix error log output](#5378)
 - [Support for native async/await in AWS Lambda for aws-nodejs-typescript template ](#5607)
 - [aws-csharp create template uses handler-specific artifact](#5411)
 - [change behaviour on initial stack create failed](#5631)
 - [Add warning for multiple functions having same handler](#5638)
 - [AWS: Add API Gateway stage name validation.](#5639)

@dschep dschep referenced this pull request Jan 9, 2019

Merged

v1.36.0 release! #5670

@shortjared shortjared added this to the 1.36.0 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment