New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5502 Support for native async/await in AWS Lambda for aws-nodejs-typescript template #5607

Merged
merged 3 commits into from Dec 31, 2018

Conversation

Projects
None yet
3 participants
@janvanzoggel
Copy link

janvanzoggel commented Dec 17, 2018

What did you implement:

Closes #5502

How did you implement it:

Changed the plugins/create/templates/aws-nodejs-typescript/tsconfig.json to contain es2017 for lib and target

How can we verify it:

Run serverless create --template aws-nodejs-typescript which should now target es2017 instead of es6

Todos:

  • [n/a] Write tests
  • [n/a] Write documentation
  • [n/a] Fix linting errors
  • [n/a] Make sure code coverage hasn't dropped
  • [n/a] Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

jan@rubix.nl and others added some commits Dec 17, 2018

jan@rubix.nl
* sorted elements on root level & compilerOptions alphabetically
* set target + lib to es2017
* added noUnusedLocals + noUnusedParameters (best practice clean code)
jan@rubix.nl
* sorted elements on root level & compilerOptions alphabetically
* set target + lib to es2017
* added noUnusedLocals + noUnusedParameters (best practice clean code)
@horike37
Copy link
Member

horike37 left a comment

@janvanzoggel
LGTM. Thanks 👍

@horike37 horike37 merged commit a15f358 into serverless:master Dec 31, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.79%
Details

dschep added a commit that referenced this pull request Jan 9, 2019

v1.36.0 release!
 - [Log AWS SDK calls in debug mode](#5604)
 - [Added currently supported regions for GCP functions](#5601)
 - [Update Cloudflare Templates](#5620)
 - [AWS: Validate rate/cron syntax before Deploy](#5635)
 - [Fix error log output](#5378)
 - [Support for native async/await in AWS Lambda for aws-nodejs-typescript template ](#5607)
 - [aws-csharp create template uses handler-specific artifact](#5411)
 - [change behaviour on initial stack create failed](#5631)
 - [Add warning for multiple functions having same handler](#5638)
 - [AWS: Add API Gateway stage name validation.](#5639)

@dschep dschep referenced this pull request Jan 9, 2019

Merged

v1.36.0 release! #5670

@shortjared shortjared added this to the 1.36.0 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment