New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Docs: Fixing link for HTTP Endpoints with AWS_IAM.. #5613

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@Murraymint1804
Copy link
Contributor

Murraymint1804 commented Dec 18, 2018

What did you implement:

The link for "HTTP Endpoints with AWS_IAM Authorizers" was broken. Changed link from:
(#http-endpoints-with-aws-iam-authorizers) to (#http-endpoints-with-aws_iam-authorizers)

Closes #XXXXX

How did you implement it:

How can we verify it: Clicking on link to see that it takes you to correct area of the docs

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • [ X] Enable "Allow edits from maintainers" for this PR
  • [X ] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Fixing link for HTTP Endpoints with AWS_IAM..
The link for "HTTP Endpoints with AWS_IAM Authorizers" was broken. Changed link from:
(#http-endpoints-with-aws-iam-authorizers) to (#http-endpoints-with-aws_iam-authorizers)

@Murraymint1804 Murraymint1804 changed the title Fixing link for HTTP Endpoints with AWS_IAM.. AWS Docs: Fixing link for HTTP Endpoints with AWS_IAM.. Dec 18, 2018

@dschep

dschep approved these changes Dec 19, 2018

Copy link
Member

dschep left a comment

Thanks for catching that! 💯

@dschep dschep merged commit e448787 into serverless:master Dec 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.777%
Details

@dschep dschep referenced this pull request Jan 9, 2019

Merged

v1.36.0 release! #5670

@shortjared shortjared added this to the 1.36.0 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment