New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating with more detail about service tracking #5618

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
4 participants
@thomcrowe
Copy link
Contributor

thomcrowe commented Dec 19, 2018

What did you implement:

Closes #XXXXX

How did you implement it: Editing text with more info from @shortjared for transparency in tracking

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: yes
Is it a breaking change?: NO

thomcrowe added some commits Dec 19, 2018

@dschep

dschep approved these changes Dec 19, 2018

Copy link
Member

dschep left a comment

:shipit:

@plfx

plfx approved these changes Dec 19, 2018

Copy link
Member

plfx left a comment

LGTM. 👍

@thomcrowe thomcrowe merged commit f543f1d into master Dec 19, 2018

3 of 5 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.781%
Details

@dschep dschep deleted the updating-tracking-info branch Dec 20, 2018

@dschep dschep referenced this pull request Jan 9, 2019

Merged

v1.36.0 release! #5670

@shortjared shortjared added this to the 1.36.0 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment