New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to populate ~/.wskprops file to OpenWhisk docs. #5625

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
3 participants
@welkie
Copy link

welkie commented Dec 24, 2018

What did you implement:

Closes #4777 by adding documentation to run a required command.

How did you implement it:

Added docs.

How can we verify it:

Set up IBM Cloud CLI on a dev machine and attempt to deploy the OpenWhisk template without performing the added step. Note that it will fail, claiming you need to set an OW_APIHOST env var.

Todos:

  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@welkie

This comment has been minimized.

Copy link

welkie commented Dec 24, 2018

Not sure why code coverage has decreased. I only modified one file, a .md file. Would appreciate it if a maintainer could assist me with this.

@dschep

dschep approved these changes Dec 28, 2018

Copy link
Member

dschep left a comment

LGTM :shipit:

@dschep dschep merged commit 5fef6ed into serverless:master Dec 28, 2018

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 90.759%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dschep dschep referenced this pull request Jan 9, 2019

Merged

v1.36.0 release! #5670

@shortjared shortjared added this to the 1.36.0 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment