Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
AWS: Add API Gateway stage name validation. #5639
What did you implement:
How did you implement it:
Add hyphen validation to
Underscore is already implemented in
How can we verify it:
Is this ready for review?: YES
I thinks stopping process is preferrable than warning. Since users can get informed before deploy, which is time consuming.
I think this idea still be a breaking change as well. there should be people who already use underscore as stagename. Is it possible to avoid it? e.g. doing validation only when detecting if CloudFront resource is used from serverless.yml.
I think restring underscore is not a breaking change, since it is already implemented in
BTW, I did not notice there is already validation until now.
Since underscore is validated when creating stack, I will remove it from my code.
Jan 4, 2019
added a commit
this pull request
Jan 9, 2019
Hello guys, just FYI: I believe this change introduced a bug when stage is referenced in serverless.yml as a variable, like this: https://serverless.com/framework/docs/providers/aws/guide/variables#recursively-reference-properties.
I'm seeing the following error:
Not sure if already captured. If so, can you please point me to the bug #?