New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare config should be under provider property #5651

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@webmasterkai
Copy link
Contributor

webmasterkai commented Jan 6, 2019

What did you implement:

As detailed in cloudflare/serverless-cloudflare-workers#1 the provider specific configuration is usually set under the provider property. cloudflare/serverless-cloudflare-workers#2 made the change.

How did you implement it:

Documentation change to stay consistent with template.

How can we verify it:

Compare documentation change to template.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@webmasterkai webmasterkai changed the title Config should be under provider property Cloudflare config should be under provider property Jan 6, 2019

@horike37
Copy link
Member

horike37 left a comment

@webmasterkai
Thanks 👍 👍 👍

@horike37 horike37 merged commit 0aa9a85 into serverless:master Jan 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.829%
Details

@dschep dschep referenced this pull request Jan 9, 2019

Merged

v1.36.0 release! #5670

@shortjared shortjared added this to the 1.36.0 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment