New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for the http key for GCF #5680

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@sparkertime
Copy link
Contributor

sparkertime commented Jan 11, 2019

What did you implement:

This adds a few notes to better explain what you can and cannot do within serverless.yml when using GCF. I hope this will address a few common questions for newcomers around HTTP verbs and path configuration in the place they are most likely to find them.

Revisions to this are more than welcome - explaining the URL configuration clearly and concisely was a challenge.

Is this ready for review?: YES
Is it a breaking change?: NO

Clarify the http key for GCP
This adds a few notes to better explain what you can and cannot do within `serverless.yml` when using GCF. I hope this will address a few common questions for newcomers around HTTP verbs and path configuration in the place they are most likely to find them.

@sparkertime sparkertime changed the title Clarify docs for the http key for GCP Clarify docs for the http key for GCF Jan 11, 2019

@pmuens

pmuens approved these changes Jan 16, 2019

Copy link
Member

pmuens left a comment

Great doc addition. Thanks @sparkertime 👍

LGTM :shipit:

@pmuens pmuens merged commit ad5decb into serverless:master Jan 16, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.847%
Details

@pmuens pmuens added pr/in-review and removed pr/in-progress labels Jan 16, 2019

@pmuens pmuens added this to the v1.36.2 milestone Jan 18, 2019

@shortjared shortjared added the docs label Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment