Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cloudformation resource reference url #5690

Merged
merged 2 commits into from Feb 15, 2019

Conversation

@joebernard
Copy link
Contributor

joebernard commented Jan 12, 2019

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@eahefnawy eahefnawy self-assigned this Jan 17, 2019

@eahefnawy eahefnawy self-requested a review Jan 17, 2019

@eahefnawy

This comment has been minimized.

Copy link
Member

eahefnawy commented Jan 17, 2019

Thanks @joebernard ... Viewing the file from your commit, It seems that the link is still broken though and Github is giving a 404.

@eahefnawy eahefnawy added this to In progress in Serverless via automation Jan 17, 2019

@eahefnawy eahefnawy requested a review from pdaryani Jan 31, 2019

@eahefnawy eahefnawy assigned pdaryani and unassigned eahefnawy Jan 31, 2019

@pmuens

pmuens approved these changes Feb 15, 2019

Copy link
Member

pmuens left a comment

Thanks for PRing this change @joebernard 👍

I just looked into it and I think I figured it out why it wasn't working before. Pushed some changes to your branch and will merge once the builds green. :shipit:

Serverless automation moved this from In progress to Reviewer approved Feb 15, 2019

@pmuens pmuens assigned pmuens and unassigned pdaryani Feb 15, 2019

@pmuens pmuens added the pr/in-review label Feb 15, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 15, 2019

@pmuens pmuens merged commit 838ab11 into serverless:master Feb 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.