Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIncrease @types/aws-lambda version in aws-nodejs-typescript template #5695
+1
−1
Conversation
pmuens
added
the
pr/in-progress
label
Jan 15, 2019
pmuens
approved these changes
Jan 16, 2019
LGTM Thanks @gabrielkaputa |
pmuens
added
pr/in-review
and removed
pr/in-progress
labels
Jan 16, 2019
pmuens
merged commit f837744
into
serverless:master
Jan 16, 2019
pmuens
added this to the v1.36.2 milestone
Jan 18, 2019
shortjared
added
the
enhancement
label
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gabrielkaputa commentedJan 13, 2019
•
edited
What did you implement:
Increased the version of @types/aws-lambda in aws-nodejs-typescript to have additional types available.
Closes #XXXXX
How did you implement it:
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO