New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array notation in stream ARN #5702

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
5 participants
@ctindel
Copy link
Contributor

ctindel commented Jan 15, 2019

Fix array notation in stream ARN

What did you implement:

Just a doc change to actually show people what works for referencing an ARN from a newly created DynamoDB stream

Closes #5671

How did you implement it:

I just changed the docs.

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Fix array notation in stream ARN
Fix array notation in stream ARN
@luanmuniz

This comment has been minimized.

Copy link
Contributor

luanmuniz commented Jan 16, 2019

@pmuens This is a documentation change. It's ready to merge

@eahefnawy eahefnawy self-assigned this Jan 17, 2019

@eahefnawy
Copy link
Member

eahefnawy left a comment

@ctindel hmmm that's really weird that it didn't work previously. They look exactly the same according to yml syntax.

Anyway, since this one works. I'm gonna merge it in! Thanks @ctindel 😊

@eahefnawy eahefnawy added this to In progress in Serverless via automation Jan 17, 2019

@eahefnawy eahefnawy merged commit be1ba38 into serverless:master Jan 17, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.847%
Details

Serverless automation moved this from In progress to Done Jan 17, 2019

@eahefnawy eahefnawy added this to the v1.36.2 milestone Jan 17, 2019

@shortjared shortjared added the bug label Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment