New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert reservedConcurrency to integer to allow use env var #5705

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
3 participants
@snurmine
Copy link
Contributor

snurmine commented Jan 15, 2019

What did you implement:

Closes #5698

How did you implement it:

Converting reservedConcurrency variable to integer

How can we verify it:

Store serverless.yaml

service: env-test

provider:
  name: aws
  runtime: nodejs6.10

functions:
    cronFunc:
        handler: handler.cronFunc
        reservedConcurrency: '${env:CONCURRENCY}'

then compile
env CONCURRENCY=10 serverless package

see
"ReservedConcurrentExecutions": 10
for example using
cat .serverless/serverless-state.json

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@pmuens pmuens self-assigned this Jan 16, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jan 16, 2019

@pmuens pmuens moved this from In progress to Needs review in Serverless Jan 16, 2019

Serverless automation moved this from Needs review to Reviewer approved Jan 23, 2019

@pmuens

pmuens approved these changes Jan 23, 2019

Copy link
Member

pmuens left a comment

LGTM :shipit: Thanks @snurmine 👍

@pmuens pmuens added pr/in-review and removed pr/in-progress labels Jan 23, 2019

@pmuens pmuens merged commit c6701ff into serverless:master Jan 23, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 90.849%
Details

Serverless automation moved this from Reviewer approved to Done Jan 23, 2019

@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment