New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Tell S3 bucket name and how to recover if deployment bucket does not exist #5714

Merged
merged 3 commits into from Jan 28, 2019

Conversation

Projects
3 participants
@exoego
Copy link
Contributor

exoego commented Jan 17, 2019

What did you implement:

Closes #5699

How did you implement it:

Translate the "The specified bucket does not exist" error into more detailed error containing below:

  • Bucket name
  • stack name
  • Possible recovery operation.

How can we verify it:

  1. npm i -g exoego/serverless#fix-5699;
  2. sls deploy anything
  3. Delete the deployment bucket manually.
  4. sls deploy
  5. Verify that new error message is shown.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@eahefnawy eahefnawy self-assigned this Jan 17, 2019

@eahefnawy eahefnawy self-requested a review Jan 17, 2019

@eahefnawy eahefnawy added this to In progress in Serverless via automation Jan 17, 2019

@eahefnawy

This comment has been minimized.

Copy link
Member

eahefnawy commented Jan 17, 2019

another great contribution @exoego 🙌 ... thanks a lot for your hard work! 💪

Please let me know if this PR is ready for review, we'd love to see test coverage for this 😊

@exoego exoego changed the title [WIP] AWS: Tell S3 bucket name and recovery operation if deployment bucket does not exist AWS: Tell S3 bucket name and how to recovery if deployment bucket does not exist Jan 17, 2019

@exoego

This comment has been minimized.

Copy link
Contributor Author

exoego commented Jan 17, 2019

@eahefnawy It's ready 😄

@exoego exoego changed the title AWS: Tell S3 bucket name and how to recovery if deployment bucket does not exist AWS: Tell S3 bucket name and how to recover if deployment bucket does not exist Jan 18, 2019

@eahefnawy eahefnawy moved this from In progress to Needs review in Serverless Jan 21, 2019

@eahefnawy
Copy link
Member

eahefnawy left a comment

Thanks @exoego .. Just a quick clarification question.

return BbPromise.reject(new this.serverless.classes.Error([
`The serverless deployment bucket "${params.Bucket}" does not exist.`,
`Create it manually if you want to reuse the CloudFormation stack "${stackName}",`,
'or delete the stack if it is no longer required.',

This comment has been minimized.

@eahefnawy

eahefnawy Jan 22, 2019

Member

@exoego what you mean "delete the stack if it is no longer required"? 🤔

This comment has been minimized.

@exoego

exoego Jan 23, 2019

Author Contributor

If I understand correctly, sls remove can not delete the stack of which the deploy bucket is deleted accidentally,
So, if user want to delete the stack which is no longer required, the stack should be manually deleted.

Serverless automation moved this from Needs review to Reviewer approved Jan 28, 2019

@eahefnawy
Copy link
Member

eahefnawy left a comment

LG2M! Thanks @exoego

@eahefnawy eahefnawy merged commit d00e677 into serverless:master Jan 28, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.1%) to 93.012%
Details

Serverless automation moved this from Reviewer approved to Done Jan 28, 2019

@exoego exoego deleted the exoego:fix-5699 branch Jan 28, 2019

@eahefnawy eahefnawy added this to the 1.36.4 milestone Jan 28, 2019

@shortjared shortjared added the bug label Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment