New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs menu sidebar - added [Getting Started] above [Providers] #5721

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@pdaryani
Copy link
Contributor

pdaryani commented Jan 18, 2019

What did you implement:

Right now, in the main docs sidebar (https://serverless.com/framework/docs/), [Getting Started] menu item appears below [Providers]. This PR moves [Getting Started] to the top

How did you implement it:

By adding [Getting Started] as the first menuItem in the respective file's frontmatter

How can we verify it:

Run a serverless/site build with this branch to see the new menu order

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep

dschep approved these changes Jan 18, 2019

@dschep
Copy link
Member

dschep left a comment

Thanks, I wasn't sure why Austen removed that but wanted to merge his PR so we could test enterprise

@ac360

This comment has been minimized.

Copy link
Member

ac360 commented Jan 18, 2019

The original issue was the Getting Started Link was being repeated, due to how the doc-generation script was configured. It looks like @pdaryani fixed this 👍

@ac360 ac360 merged commit 9359cea into master Jan 18, 2019

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.008%
Details

@shortjared shortjared added the docs label Jan 22, 2019

@shortjared shortjared added this to the v1.36.2 milestone Jan 22, 2019

@pmuens pmuens deleted the docs-getting-started-menu-item-above-providers branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment