New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-scala-sbt template #5725

Merged
merged 6 commits into from Jan 21, 2019

Conversation

Projects
3 participants
@NomadBlacky
Copy link
Contributor

NomadBlacky commented Jan 19, 2019

What did you implement:

Closes #XXXXX

How did you implement it:

  • Bump up dependencies.
  • Tweak build definitions.

How can we verify it:

$ sls create -t aws-scala-sbt -p sls-scala
$ cd sls-scala
$ sbt sbtVersion # Please check the display of `1.2.8`
$ sbt scalaVersion # Please check the display of `2.12.8`
$ sbt assembly
$ sls deploy
$ sls invoke -f hello

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added the pr/in-review label Jan 21, 2019

@pmuens

pmuens approved these changes Jan 21, 2019

Copy link
Member

pmuens left a comment

Thanks @NomadBlacky 👍

LGTM :shipit:

@pmuens pmuens self-assigned this Jan 21, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jan 21, 2019

@pmuens pmuens merged commit 584aadf into serverless:master Jan 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.008%
Details

Serverless automation moved this from In progress to Done Jan 21, 2019

@shortjared shortjared added this to the v1.36.2 milestone Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment