New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google go template #5726

Merged
merged 5 commits into from Jan 22, 2019

Conversation

@toshi0607
Copy link
Contributor

toshi0607 commented Jan 20, 2019

What did you implement:

close #5724

Cloud Functions Go runtime has bees released! 馃帀 So I wrote a template for it.

How did you implement it:

I added template, list of template and tests.

How can we verify it:

# Go 1.11 is necessary
# $GOPATH should be set

$ cd $GOPATH/src/github.com/[your repo]
$ serverless create -t google-go -p sample-app
$ cd sample-app
$ make gomodgen

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@exoego

This comment has been minimized.

Copy link
Contributor

exoego commented Jan 20, 2019

馃憤

I think this PR closes #5724

@toshi0607

This comment has been minimized.

Copy link
Contributor Author

toshi0607 commented Jan 20, 2019

@exoego Thanks! I updated description.

@pmuens
Copy link
Member

pmuens left a comment

Great stuff!
Thanks a lot for working on this @toshi0607 馃憤

I've looked through this and there are just 2 minor "issues". Other than that it's GTM :shipit:

@@ -102,6 +102,10 @@ services:
image: node:6.9.1
volumes:
- ./tmp/serverless-integration-test-google-nodejs:/app
google-nodejs:

This comment has been minimized.

@pmuens

pmuens Jan 21, 2019

Member

Shouldn't this be google-go or google-golang?

wantStatus int
wantString string
}{
"name specified": {"toshi0607", http.StatusOK, "Hello, toshi0607!"},

This comment has been minimized.

@pmuens

pmuens Jan 21, 2019

Member

Could you make this more general like jdoe or something like that?

@pmuens pmuens self-assigned this Jan 21, 2019

@pmuens pmuens added the pr/in-review label Jan 21, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jan 21, 2019

@pmuens pmuens changed the title add google go template Add google go template Jan 21, 2019

@toshi0607

This comment has been minimized.

Copy link
Contributor Author

toshi0607 commented Jan 21, 2019

@pmuens Thanks! I fixed issues.

@sebito91
Copy link
Member

sebito91 left a comment

Small nits but I think this looks great!

Show resolved Hide resolved docker-compose.yml
Show resolved Hide resolved lib/plugins/create/templates/google-go/serverless.yml

Serverless automation moved this from In progress to Reviewer approved Jan 22, 2019

@pmuens

pmuens approved these changes Jan 22, 2019

Copy link
Member

pmuens left a comment

Great addition! Thanks for addressing all the PR review comments 馃憤

LGTM :shipit:

@pmuens pmuens merged commit 7bc381e into serverless:master Jan 22, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.008%
Details

Serverless automation moved this from Reviewer approved to Done Jan 22, 2019

@shortjared shortjared added this to the v1.36.3 milestone Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment