Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTest that CLI does not convert numeric option to number #5727
Conversation
exoego
force-pushed the
exoego:cli-arg-test
branch
from
cef6e8d
to
622be4b
Jan 20, 2019
pmuens
added
the
pr/in-review
label
Jan 21, 2019
horike37
approved these changes
Jan 21, 2019
eahefnawy
self-assigned this
Jan 21, 2019
eahefnawy
self-requested a review
Jan 21, 2019
eahefnawy
added this to In progress
in Serverless
via automation
Jan 21, 2019
eahefnawy
approved these changes
Jan 22, 2019
Serverless
automation
moved this from In progress
to Reviewer approved
Jan 22, 2019
eahefnawy
merged commit 1d1d869
into
serverless:master
Jan 22, 2019
Serverless
automation
moved this from Reviewer approved
to Done
Jan 22, 2019
shortjared
added
the
enhancement
label
Jan 22, 2019
shortjared
added this to the v1.36.3 milestone
Jan 22, 2019
exoego
deleted the
exoego:cli-arg-test
branch
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
exoego commentedJan 20, 2019
•
edited
What did you implement:
Closes #4073
Closes #4872
In reality, the original issues seems already fixed somewhere before v1.36.1
How did you implement it:
This PR just add test to confirm that numeric string is not converted to number.
So future refactoring never break the expected behavior.
How can we verify it:
Todos:
Write documentationN/AIs this ready for review?: YES
Is it a breaking change?: NO