New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that CLI does not convert numeric option to number #5727

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@exoego
Copy link
Contributor

exoego commented Jan 20, 2019

What did you implement:

Closes #4073
Closes #4872

In reality, the original issues seems already fixed somewhere before v1.36.1

How did you implement it:

This PR just add test to confirm that numeric string is not converted to number.
So future refactoring never break the expected behavior.

How can we verify it:

  1. Install v.1.36.1
  2. Run configuration in #4073 (comment)

Todos:

  • Write tests
  • Write documentation N/A
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@exoego exoego force-pushed the exoego:cli-arg-test branch from cef6e8d to 622be4b Jan 20, 2019

@pmuens pmuens added the pr/in-review label Jan 21, 2019

@horike37
Copy link
Member

horike37 left a comment

@exoego LGTM 👍

@eahefnawy eahefnawy self-assigned this Jan 21, 2019

@eahefnawy eahefnawy self-requested a review Jan 21, 2019

@eahefnawy eahefnawy added this to In progress in Serverless via automation Jan 21, 2019

Serverless automation moved this from In progress to Reviewer approved Jan 22, 2019

@eahefnawy eahefnawy merged commit 1d1d869 into serverless:master Jan 22, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.008%
Details

Serverless automation moved this from Reviewer approved to Done Jan 22, 2019

@shortjared shortjared added this to the v1.36.3 milestone Jan 22, 2019

@exoego exoego deleted the exoego:cli-arg-test branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment