New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link #5731

merged 2 commits into from Jan 24, 2019


4 participants
Copy link

kazufumi-nishida-www commented Jan 21, 2019

What did you implement:

Fix broken link.

How did you implement it:

Replace broken link with correct it.

How can we verify it:

Compare fixed link path and real path


  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added the pr/in-review label Jan 21, 2019

Copy link

pmuens left a comment

Thanks for working on a fix @kazufumi-nishida-www 👍

Could you update the other links as well. Seems like the reference is not needed in any of those...

@pmuens pmuens self-assigned this Jan 21, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jan 21, 2019

Serverless automation moved this from In progress to Reviewer approved Jan 24, 2019


pmuens approved these changes Jan 24, 2019

Copy link

pmuens left a comment

Just pushed another minor fix.

Will merge after the build is green :shipit:

@pmuens pmuens merged commit cff7161 into serverless:master Jan 24, 2019

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 93.006%
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

Serverless automation moved this from Reviewer approved to Done Jan 24, 2019

@kazufumi-nishida-www kazufumi-nishida-www deleted the kazufumi-nishida-www:patch-1 branch Jan 24, 2019


This comment has been minimized.

Copy link
Contributor Author

kazufumi-nishida-www commented Jan 24, 2019

Thanks for after follow.

@dschep dschep added this to the 1.37.0 milestone Feb 5, 2019

@shortjared shortjared added the docs label Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment