New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate-handler warnings based on community feedback. #5733

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@exoego
Copy link
Contributor

exoego commented Jan 22, 2019

What did you implement:

Closes #5689

How did you implement it:

Remove the warning introduced in #5689 completely.

Please refer the discussions in #5729 for removal.

How can we verify it:

  1. sls install -g exoego/serverless#remove-duplicate-handler-warning
  2. Prepare the below yml.
service: 
  name: myservice
provider:
  name: aws
  runtime: nodejs8.10
functions:
  function1:
    handler: lib/proxy.handler
  function2:
    handler: lib/proxy.handler
  1. sls package, then it should NOT print duplicate handlers warnings.

Todos:

  • Write tests N/A
  • Write documentation N/A
  • Fix linting errors
  • Make sure code coverage hasn't dropped ⚠️ Dropped due to removal of codes.
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@exoego exoego referenced this pull request Jan 22, 2019

Closed

Add option to configure duplicate-handlers warnings #5729

7 of 7 tasks complete

@exoego exoego referenced this pull request Jan 22, 2019

Merged

Do not print logs if print command is used. #5728

7 of 7 tasks complete

@horike37 horike37 self-assigned this Jan 22, 2019

@horike37
Copy link
Member

horike37 left a comment

Thank you for taking care of it @exoego 👍
Please remove explanation of warnDuplicateHandlers from docs/providers/aws/guide/serverless.yml.md as well.

@exoego

This comment has been minimized.

Copy link
Contributor Author

exoego commented Jan 22, 2019

Please remove explanation of warnDuplicateHandlers from docs/providers/aws/guide/serverless.yml.md as well.

An explanation of warnDuplicateHandlers introduced in #5729 is not merged.
So no need to remove it in this PR.

@eahefnawy
Copy link
Member

eahefnawy left a comment

Thanks for responding to our feedback @exoego 😊

@horike37 Feel free to merge

@horike37 horike37 merged commit 44f3d16 into serverless:master Jan 22, 2019

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.009%) to 93.012%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shortjared shortjared added this to the v1.36.3 milestone Jan 22, 2019

@exoego exoego deleted the exoego:remove-duplicate-handler-warnings branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment