New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sls plugin install -n @scoped/package #5736

Merged
merged 4 commits into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@dschep
Copy link
Member

dschep commented Jan 22, 2019

What did you implement:

Allow sls plugin install -n @serverless/enterprise-plugin for example

How did you implement it:

if the plugin name starts with an @ follow different logic for splitting on @ to get the version.

How can we verify it:

install this branch of sls, then run sls plugin install -n @serverless/enterprise-plugin

Todos:

  • Write tests
  • [n/a] Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

dschep added some commits Jan 22, 2019

@dschep dschep requested review from pmuens and eahefnawy Jan 22, 2019

@alexdebrie
Copy link
Contributor

alexdebrie left a comment

Worked for me. :shipit:

@dschep dschep merged commit 253b651 into master Jan 22, 2019

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.004%
Details

@dschep dschep deleted the scoped-plugin-install branch Jan 22, 2019

@shortjared shortjared added this to the v1.36.3 milestone Jan 23, 2019

@shortjared shortjared added the bug label Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment