Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Resolve profile before performing aws-sdk dependent actions #5744
What did you implement:
How did you implement it:
How can we verify it:
Is this ready for review?: YES
referenced this pull request
Jan 23, 2019
pmuens left a comment •
Looks good from a code perspective
I read through the comments re: breaking changes, but it looks like this is just an addition, so we should be fine here.
I'm not sure how important this PR is. We could merge it right away but I'd love to have a unit test covering this (won't "Request changes") to not block here...
(Or is this already covered by a test
Agreed, the switch to be additive rather than replacing avoidsthis being a breaking change except in extreme circumstances that I think we accept.
Agreed there's a need for tests. Something like a variable resolving to a valid value then being used by an SSM, S3, whatever variable which will fail but we can catch that expected failure and ensure the profile resolved properly.