New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hello World Ruby Example #5754

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
4 participants
@yuki3738
Copy link
Contributor

yuki3738 commented Jan 26, 2019

What did you implement:

Added hello world example document for Ruby.

Closes #XXXXX

How did you implement it:

Based on python document.

ref: https://github.com/serverless/serverless/blob/master/docs/providers/aws/examples/hello-world/python/README.md

How can we verify it:

Please confirm the document.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@yuki3738 yuki3738 force-pushed the yuki3738:add-helloworld-example-for-ruby branch from 88c780c to 279c85e Jan 26, 2019

@eahefnawy eahefnawy self-assigned this Jan 28, 2019

@eahefnawy eahefnawy added this to In progress in Serverless via automation Jan 28, 2019

@eahefnawy eahefnawy self-requested a review Jan 28, 2019

Serverless automation moved this from In progress to Reviewer approved Jan 28, 2019

@eahefnawy
Copy link
Member

eahefnawy left a comment

Thanks @yuki3738

@eahefnawy eahefnawy merged commit 92c38ab into serverless:master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Jan 28, 2019

@yuki3738 yuki3738 deleted the yuki3738:add-helloworld-example-for-ruby branch Jan 28, 2019

@dschep dschep added this to the 1.36.4 milestone Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment