Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPreserve whitespaces in single-quote literal fallback #5775
Conversation
exoego
added some commits
Feb 2, 2019
pmuens
approved these changes
Feb 3, 2019
pmuens
added this to In progress
in Serverless
via automation
Feb 3, 2019
pmuens
added
the
pr/in-review
label
Feb 3, 2019
pmuens
merged commit 398a92a
into
serverless:master
Feb 3, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Serverless
automation
moved this from In progress
to Done
Feb 3, 2019
exoego
deleted the
exoego:single-quote-fallback
branch
Feb 3, 2019
dschep
added this to the 1.37.0 milestone
Feb 5, 2019
shortjared
added
the
bug
label
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
exoego commentedFeb 2, 2019
•
edited
What did you implement:
Closes #5398
How did you implement it:
In #5594,
cleanVariable
does not clean whitespaces if variable is double-quote string literal.Atter this PR, it also does not clean whitespace if variable is single-quote string literal.
How can we verify it:
npm install -g exoego/serverless#single-quote-fallback
sls deploy
below and confirm it completes successfully.Todos:
Write documentationIs this ready for review?: YES
Is it a breaking change?: NO