New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for AWS cors config issues #5785

Merged
merged 5 commits into from Feb 4, 2019

Conversation

Projects
3 participants
@pchynoweth
Copy link
Contributor

pchynoweth commented Feb 4, 2019

What did you implement:

Closes #5779
Closes #5780

  • Now checking if origins is empty to ensure origin is only set where appropriate.
  • validate.js now copies cacheControl into corsPreflight so the configured value is available in compileCors().

How did you implement it:

See above.

How can we verify it:

Modified existing unit tests to cover these scenarios and tested with my own stack. The linked issues describe how to recreate.

Todos:

  • Write tests
  • Write documentation N/A - Bug fixes only.
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources (see linked issues)
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

***Is this ready for review?: YES
***Is it a breaking change?: NO

@eahefnawy
Copy link
Member

eahefnawy left a comment

Very good catch @pchynoweth ... LG2M!

@eahefnawy eahefnawy self-assigned this Feb 4, 2019

@eahefnawy eahefnawy added this to In progress in Serverless via automation Feb 4, 2019

@eahefnawy eahefnawy added this to the 1.36.4 milestone Feb 4, 2019

@eahefnawy eahefnawy merged commit 61d3af3 into serverless:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from In progress to Done Feb 4, 2019

@shortjared shortjared added the bug label Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment