New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use Secrets Manager #5788

Merged
merged 4 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@dschep
Copy link
Member

dschep commented Feb 4, 2019

What did you implement:

closes #5024

Thanks to @alexdebrie for pointing me to the AWS docs on how to use Secrets Manager via SSM: https://docs.aws.amazon.com/systems-manager/latest/userguide/integration-ps-secretsmanager.html

How did you implement it:

Added documentation on how to use Secrets Manager via SSM

How can we verify it:

Create a secret and try to use it via an ${ssm:/aws/reference/secretsmanager/secret_ID_in_Secrets_Manager~true}:

Todos:

  • Write tests
  • Write documentation
  • n/a Fix linting errors
  • n/a Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested a review from alexdebrie Feb 4, 2019

@alexdebrie
Copy link
Contributor

alexdebrie left a comment

Two small changes, but otherwise looks good!

Can you also add a link in the table of contents so people know it's available?

Show resolved Hide resolved docs/providers/aws/guide/variables.md Outdated
Show resolved Hide resolved docs/providers/aws/guide/variables.md Outdated

alexdebrie and others added some commits Feb 4, 2019

Update docs/providers/aws/guide/variables.md
Co-Authored-By: dschep <dschep@gmail.com>
Update docs/providers/aws/guide/variables.md
Co-Authored-By: dschep <dschep@gmail.com>
@alexdebrie
Copy link
Contributor

alexdebrie left a comment

LGTM!

@dschep dschep merged commit 04a2a65 into master Feb 4, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@dschep dschep deleted the secrets-via-ssm branch Feb 4, 2019

@dschep dschep added this to the 1.36.4 milestone Feb 5, 2019

@shortjared shortjared added the docs label Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment