Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set timout & others on context in python invoke local #5796

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
3 participants
@dschep
Copy link
Member

dschep commented Feb 5, 2019

What did you implement:

closes #5792

How did you implement it:

set the same default context as the java invoke local implementation

How can we verify it:

run @mnylen's example repo in #5792

Todos:

  • Write tests
  • n/a Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

dschep added some commits Feb 5, 2019

@dschep

This comment has been minimized.

Copy link
Member Author

dschep commented Feb 5, 2019

@mnylen do you mind checking that this fixes your issue? Install this branch with npm i -g serverless/serverless#sls-5792

@pmuens pmuens self-assigned this Feb 6, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 6, 2019

@pmuens pmuens added the pr/in-review label Feb 6, 2019

@mnylen

This comment has been minimized.

Copy link

mnylen commented Feb 6, 2019

@dschep Yup! Seems to print 900000 for context.get_remaining_time_in_millis() using this branch. 👍

Serverless automation moved this from In progress to Reviewer approved Feb 6, 2019

@pmuens

pmuens approved these changes Feb 6, 2019

Copy link
Member

pmuens left a comment

This looks good 👍

Just tested it and it works as expected. Thanks for fixing this @dschep 💯

Do we need tests for this? I looked through the tests of this functionality and it seems that they fail on CI anyways.

If not I'd say it's GTM :shipit:

@pmuens pmuens changed the title set timout&others on context in python invoke local Set timout & others on context in python invoke local Feb 6, 2019

@dschep dschep merged commit a9fa9bf into master Feb 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 6, 2019

@dschep dschep deleted the sls-5792 branch Feb 6, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.