Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load config for `config` #5798

Merged
merged 2 commits into from Feb 7, 2019

Conversation

Projects
2 participants
@erikerikson
Copy link
Member

erikerikson commented Feb 5, 2019

What did you implement:

Change the config command to not require loading of the serverless.* configuration file.

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • [n/a] Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Don't load config for `config`
Change the config command to not require loading of the `serverless.*` configuration file.

Fixes #4597
@erikerikson

This comment has been minimized.

Copy link
Member Author

erikerikson commented Feb 6, 2019

This doesn't resolve the problem of #4597, though it is correct.

@pmuens pmuens self-assigned this Feb 6, 2019

@pmuens pmuens added the pr/in-review label Feb 6, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 6, 2019

Serverless automation moved this from In progress to Needs review Feb 6, 2019

@pmuens
Copy link
Member

pmuens left a comment

Thanks for working on this @erikerikson 🙏 🥇

This change looks reasonable and correct. Could we get rid of the package-lock.json file in the PR? I can address that if you're too busy! Additionally do you think there are tests which should be added here? Not sure if we've ever added tests for this (or if it even makes sense to add tests at all).

@erikerikson

This comment has been minimized.

Copy link
Member Author

erikerikson commented Feb 6, 2019

Happy to remove package lock. Can do that in a bit.

I'm really unsure what tests would look like against this declaration or, really, how much value it would provide. Such tests seem more likely to be part of the original addition of this flag.

@pmuens

This comment has been minimized.

Copy link
Member

pmuens commented Feb 7, 2019

Happy to remove package lock. Can do that in a bit.

I'm really unsure what tests would look like against this declaration or, really, how much value it would provide. Such tests seem more likely to be part of the original addition of this flag.

Thanks for getting back @erikerikson 👍

I agree, that testing this doesn't really make sense here. I was not familiar with the overall functionality so I thought that I'll just bring this up. I jumped in real quick and removed the package-lock.json changes. Will merge once the build is green :shipit:

Thanks again for working on this 👌

@pmuens

pmuens approved these changes Feb 7, 2019

Copy link
Member

pmuens left a comment

LGTM :shipit:

Serverless automation moved this from Needs review to Reviewer approved Feb 7, 2019

@pmuens pmuens merged commit aeb780d into serverless:master Feb 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 7, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 7, 2019

@erikerikson

This comment has been minimized.

Copy link
Member Author

erikerikson commented Feb 7, 2019

Thanks for covering me on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.