Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace \ with / in paths on windows before passing to nanomatch #5808
What did you implement:
fixes #5745 because nanomatch only supports / as a path separator
How did you implement it:
How can we verify it:
then if you check
Is this ready for review?: YES
pmuens left a comment •
Great fix and great "steps-to-reproduce" description
Tested it on my Mac and it's still working (don't have a Windows machine handy).
Not sure if we should add a regression test here since we would mock anyways. Might be wortwhile to have smth. like that but since this bug is module-dependent and basically popped up because of "misuse" I'm fine with moving forward and merging w/o havin a regression test in place..