Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makeDeepVariable replacement #5809

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
2 participants
@jerizm
Copy link
Contributor

jerizm commented Feb 7, 2019

What did you implement:

Closes #5807

How did you implement it:

5ed78b8 added preservation of white space in a single-quote literal. This caused makeDeepVariable to not replace the variableString properly with the deep:0 syntax because white space was only being removed from the variableContainer.

To fix I just added the removal of white space from variableString as well.

How can we verify it:

I added a new test for the case for it. The sample in #5807 works as well now.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@pmuens

pmuens approved these changes Feb 8, 2019

Copy link
Member

pmuens left a comment

Thanks for jumping in and fixing this right away @jerizm 👍 🥇

I just tested it and it fixes the bug! Merging... :shipit:

@pmuens pmuens merged commit 89be59c into serverless:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pmuens pmuens self-assigned this Feb 8, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 8, 2019

@pmuens pmuens added the pr/in-review label Feb 8, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 8, 2019

@pmuens pmuens moved this from In progress to Done in Serverless Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.