Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deploying GoLang to AWS from Windows! #5813

Merged
merged 7 commits into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@dschep
Copy link
Member

dschep commented Feb 8, 2019

What did you implement:

Closes #5614

cc @lolcoolkat

How did you implement it:

If on windows, the handler files when added to the zip have their mode modified to add the execute permission.

How can we verify it:

Install with npm i -g serverless/serverless#win-go and deploy the aws-go template from a windows machine and invoke the lambda

Todos:

  • Write tests
  • n/a Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested review from eahefnawy and sebito91 Feb 8, 2019

@sebito91
Copy link
Member

sebito91 left a comment

LGTM, well done tracking this down!

@lolcoolkat

This comment has been minimized.

Copy link

lolcoolkat commented Feb 8, 2019

Thank you so much @dschep @sebito91 @eahefnawy and everyone else who contributed to get this solved! I really appreciate it!!! Can't wait to start deploying GO code on Windows ❤️

@sebito91
Copy link
Member

sebito91 left a comment

two thumbs up!

@dschep dschep merged commit d584315 into master Feb 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dschep dschep deleted the win-go branch Feb 8, 2019

@eahefnawy eahefnawy added this to the 1.38.0 milestone Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.