Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Google Python function template #5819
What did you implement:
Added a template for a Google Python function.
How did you implement it:
Basically I just copied the Google NodeJS template, changed the runtime, added a "main.py" and ran it against my GCP account to verify it was working.
How can we verify it:
After merge it should be possible to run:
To create the service/function and then run the standard:
to test it.
Is this ready for review?: YES
pmuens left a comment
This looks great! Thanks for adding this @srkiNZ84
AFAIK we have a couple of other places where we list our templates. Could you do a global search for
Other than that it should be GTM soon!
Let us know if you have any questions / problems...
Cheers for the quick review! I've had a search for all instances of "google-nodejs" to see where it is being used by running "grep -Ri google-nodejs ./*" and have updated all the places I think needed to be updated.
I've also included a new test for the "create" action that verifies all the files are there (including "main.py").
Please take a look and let me know whether I have missed something or could have done something better.