Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Python function template #5819

Merged
merged 5 commits into from Feb 12, 2019

Conversation

Projects
2 participants
@srkiNZ84
Copy link

srkiNZ84 commented Feb 9, 2019

What did you implement:

Added a template for a Google Python function.

How did you implement it:

Basically I just copied the Google NodeJS template, changed the runtime, added a "main.py" and ran it against my GCP account to verify it was working.

How can we verify it:

After merge it should be possible to run:

serverless create --template google-python --path my-service

To create the service/function and then run the standard:

npm install
serverless deploy
serverless invoke --function first

to test it.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Serge Dukic added some commits Feb 9, 2019

Serge Dukic
Add Google Cloud Python template
Add a template for creating Python Serverless functions in Google Cloud.

Issue(s): None
Serge Dukic
Fix typo in service name
Needs a space before the "hash" symbol otherwise YAML doesn't recognise
it as a comment.

Issue(s): None
Serge Dukic
Fix function name to be "http"
So that it matches what is in the "serverless.yml" file.

Issue(s): None

@pmuens pmuens self-assigned this Feb 10, 2019

@pmuens pmuens added the pr/in-review label Feb 10, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 10, 2019

@pmuens
Copy link
Member

pmuens left a comment

This looks great! Thanks for adding this @srkiNZ84 👌 💯

AFAIK we have a couple of other places where we list our templates. Could you do a global search for google-nodejs. This should bring up all the places in the docs where we reference such templates.

Other than that it should be GTM soon! :shipit:

Let us know if you have any questions / problems...

Serverless automation moved this from In progress to Needs review Feb 11, 2019

Serge Dukic added some commits Feb 12, 2019

Serge Dukic
Added documentation for GCP Python HelloWorld function
Copied the pattern from the NodeJS documentation. Hopefully it all links
up nicely.

Issue(s): None
Serge Dukic
Include Google Python template tests
Add a test for the Google Cloud Platform Python template test and also
update a couple of the documents as well.

Issue(s): None
@srkiNZ84

This comment has been minimized.

Copy link
Author

srkiNZ84 commented Feb 12, 2019

Cheers for the quick review! I've had a search for all instances of "google-nodejs" to see where it is being used by running "grep -Ri google-nodejs ./*" and have updated all the places I think needed to be updated.

I've also included a new test for the "create" action that verifies all the files are there (including "main.py").

Please take a look and let me know whether I have missed something or could have done something better.

Thank you

Serverless automation moved this from Needs review to Reviewer approved Feb 12, 2019

@pmuens

pmuens approved these changes Feb 12, 2019

Copy link
Member

pmuens left a comment

Amazing! 👍

Thanks for the quick turnaround and the additions 👌💯

Merging :shipit:

@pmuens pmuens merged commit e98127b into serverless:master Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 12, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.