Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate unused context in aws-nodejs-typescipt #5832

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
2 participants
@Xenonym
Copy link
Contributor

Xenonym commented Feb 13, 2019

What did you implement:

Closes #5773.

How did you implement it:

I added a underscore to the context variable in handler.ts in the aws-nodejs-typescript template to indicate that it is unused as per Microsoft/TypeScript#9464.

How can we verify it:

The following sequence of commands should not emit errors and the deploy should be successful:

serverless create --template aws-nodejs-typescript
npm install
serverless deploy

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Indicate unused context in aws-nodejs-typescipt
- _ is used to exclude variables from unused parameter checks (Microsoft/TypeScript#9464)

@pmuens pmuens self-assigned this Feb 14, 2019

@pmuens pmuens added the pr/in-review label Feb 14, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 14, 2019

Serverless automation moved this from In progress to Reviewer approved Feb 14, 2019

@pmuens

pmuens approved these changes Feb 14, 2019

Copy link
Member

pmuens left a comment

Great! Thanks for fixing this @Xenonym 👍

Just tested it out and it works like a charm. Merging... :shipit:

@pmuens pmuens added this to the 1.38.0 milestone Feb 14, 2019

@pmuens pmuens merged commit 0688c4f into serverless:master Feb 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 14, 2019

@Xenonym Xenonym deleted the Xenonym:fix/aws-nodejs-ts-unused-context branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.