Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing underscore #5836

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
3 participants
@pheuberger
Copy link
Contributor

pheuberger commented Feb 14, 2019

Looking at the remainder of the documentation it seems that the Message Hub event key should be message_hub and not messagehub.

Missing underscore
Looking at the remainder of the documentation it seems that the Message Hub event key should be `message_hub` and not `messagehub`.

@dschep dschep added the docs label Feb 14, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 15, 2019

@pmuens pmuens added the pr/in-review label Feb 15, 2019

@pmuens pmuens self-assigned this Feb 15, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 15, 2019

Serverless automation moved this from In progress to Reviewer approved Feb 15, 2019

@pmuens

pmuens approved these changes Feb 15, 2019

Copy link
Member

pmuens left a comment

Thanks for fixing @pheuberger 👍

Looked into the code and you're right! Merging :shipit:

@pmuens pmuens merged commit c5a20c4 into serverless:master Feb 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 15, 2019

@pheuberger pheuberger deleted the pheuberger:patch-1 branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.