Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Replacing "runtimes" with "templates" #5843

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
2 participants
@luciansr
Copy link
Contributor

luciansr commented Feb 17, 2019

What did you implement:

The documentation page was describing that there was a list of runtimes, when in fact its a list of templates

How did you implement it:

Replaced:
Here are the available runtimes for AWS Lambda:
with
Here are the available templates for AWS Lambda:

Because these are in fact templates and not actual runtimes in AWS Lambda

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Replacing "runtimes" with "templates"
Replaced:
Here are the available runtimes for AWS Lambda:
with
Here are the available templates for AWS Lambda:

@luciansr luciansr changed the title Replacing "runtimes" with "templates" [Docs] Replacing "runtimes" with "templates" Feb 17, 2019

@pmuens pmuens self-assigned this Feb 17, 2019

@pmuens pmuens added the pr/in-review label Feb 17, 2019

@pmuens pmuens added this to In progress in Serverless via automation Feb 17, 2019

Serverless automation moved this from In progress to Reviewer approved Feb 18, 2019

@pmuens

pmuens approved these changes Feb 18, 2019

Copy link
Member

pmuens left a comment

LGTM. Thanks @luciansr 👍

@pmuens pmuens merged commit 640270b into serverless:master Feb 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Feb 18, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.