Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Websockets: Support more route characters #5865
What did you implement:
How did you implement it:
Replace special characters with alphanumeric ones, as we've done with other logical IDs
How can we verify it:
functions: hello: handler: handler.hello events: - websocket: 'echo' - websocket: 'echo/echo' - websocket: 'echo-echo' - websocket: 'echo_echo' - websocket: 'echo.echo'
Is this ready for review?: YES
pmuens left a comment
Looks good so far
I agree with @dschep that it might be better if the Ids follow our general naming conventions we've used for other events. However I understanding the thinking here that there could be multiple
Nevertheless we might want to update the docs and add our Websocket logical id schema there.
FWIW here's what I found today, so we should stick to the pattern of replacing