Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Capability when Transform is detected #5997

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
3 participants
@pofallon
Copy link
Contributor

commented Apr 4, 2019

What did you implement:

Closes #5995

How did you implement it:

When creating or updating a stack, it checks the CloudFormation template to see if a Transform directive is found. If it is, it adds the additional capability CAPABILITY_AUTO_EXPAND, which is required when using a CloudFormation Macro via the Transform directive.

How can we verify it:

This serverless.yml should be successfully deployed:

service: transform-test

provider:
  name: aws

resources:
  Transform: 'AWS::Serverless-2016-10-31'
  Resources:
    SimpleTable:
      Type: AWS::Serverless::SimpleTable
      Properties:
        PrimaryKey:
          Name: id
          Type: String
        ProvisionedThroughput:
          ReadCapacityUnits: 5
          WriteCapacityUnits: 5

Todos:

(I'm not sure what documentation would be required for this, but I'm happy to add some if necessary...)

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added the pr/in-review label Apr 8, 2019

@pmuens pmuens self-assigned this Apr 8, 2019

@pmuens

pmuens approved these changes Apr 8, 2019

Copy link
Member

left a comment

Thanks for PRing @pofallon 👍

Just tested it and it works great. LGTM :shipit:

@pmuens pmuens merged commit 986f4db into serverless:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pmuens pmuens added this to In progress in Serverless via automation Apr 8, 2019

@pmuens pmuens added this to the 1.41.0 milestone Apr 8, 2019

@pmuens pmuens moved this from In progress to Done in Serverless Apr 8, 2019

@dschep dschep added the enhancement label Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.