Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quick-start.md #6018

Merged
merged 2 commits into from Apr 15, 2019
Merged

Update quick-start.md #6018

merged 2 commits into from Apr 15, 2019

Conversation

@allanchua101
Copy link
Contributor

allanchua101 commented Apr 14, 2019

I've specified that the Node v 6.5.0 is minimum run-time version required to reduce confusion from reader's point of view.

What did you implement:

I've specified that the Node v 6.5.0 is minimum run-time version required to reduce confusion from reader's point of view.

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • [X ] Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

I've specified that the Node v 6.5.0 is minimum run-time version required to reduce confusion from reader's point of view.
@pmuens
pmuens approved these changes Apr 15, 2019
Copy link
Member

pmuens left a comment

LGTM :shipit:

Thanks @allanchua101 👍

@pmuens pmuens added this to In progress in Serverless via automation Apr 15, 2019
@pmuens pmuens added this to the 1.41.0 milestone Apr 15, 2019
@pmuens pmuens merged commit 4dbdee0 into serverless:master Apr 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Serverless automation moved this from In progress to Done Apr 15, 2019
@allanchua101

This comment has been minimized.

Copy link
Contributor Author

allanchua101 commented Apr 15, 2019

@pmuens Is there anything that I can help improve with the docs atm?

@pmuens pmuens self-assigned this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Serverless
  
Done
2 participants
You can’t perform that action at this time.