Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove default stage value in provider object #6200
What did you implement:
the current default is using AWS region naming syntax,
Instead, region default should be left to each provider.
How did you implement it:
one line code change
How can we verify it:
Is this ready for review?: YES
Hey @mydiemho thanks for updating the PR
Yes, sometimes Travis has some hiccups. Seems like the build was running and is now successful (I had to fix some minor linting issues and pushed the changes directly to your branch).
I tested this bu deploying one stack to the
Usually removing stuff from the core is a tricky thing because it can result in breaking changes. I faced the same issue you described while working on the Google Cloud Functions plugin. Looking at the code the change which is introduced here is bound to a
However, I'd love to get some more feedback on this. @medikoo could you also glance over this? Would this removal result in a breaking change
medikoo left a comment •
I'm totally in for this change (great thanks @mydiemho !)
I believe at core we should be provider agnostic, and this cleanup seems desirable.
But maybe some plugins depend on existence of it? @pmuens if you feel it's risky we may mark it as potentially breaking and ship with nearest "major" (or breaking) release.
@pmuens thanks for the lint fix. What command did you use for the fix? We should add that as a npm script so others can use it.
@mydiemho I'm using an extension in my IDE. That way I see ESLint issue right away.
So I looked into this again today. Read through the provider codebases under the
I'd propose that we discuss this with the team to get more feedback on this. Maybe @eahefnawy know why this code was added there. Once confirmed we can merge this right away.
Jun 21, 2019
1 check passed
Not sure if I am doing something wrong, but seems like this change is a breaking one, for me.
When I do not configure a region anywhere for the Serverless Framework (not as cli param and not in the serverless.yml), and then I relate to self:provider.region, I get no value as of v1.46.0. This worked with 1.45.1.
@medikoo I'm not sure, I've fixed it by manually setting region in serverless.yml. This was the error I got in CI when creating/migrating the dynamodb local tables: