Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala version to 2.13.0 for aws-scala-sbt template #6222

Merged
merged 3 commits into from Jun 8, 2019

Conversation

@NomadBlacky
Copy link
Contributor

commented Jun 8, 2019

What did you implement:

Closes #XXXXX

How did you implement it:

  • Fix scalaVersion in build.sbt.
  • Migrate codebase to Scala 2.13.0.

How can we verify it:

$ tests/templates/integration-test-template aws-scala-sbt sbt assembly

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@@ -3,4 +3,4 @@ package hello
import scala.beans.BeanProperty

case class ApiGatewayResponse(@BeanProperty statusCode: Integer, @BeanProperty body: String,
@BeanProperty headers: java.util.Map[String, Object], @BeanProperty base64Encoded: Boolean = false)
@BeanProperty headers: java.util.Map[String, String], @BeanProperty base64Encoded: Boolean = false)

This comment has been minimized.

Copy link
@NomadBlacky
@@ -3,7 +3,7 @@ package hello
import com.amazonaws.services.lambda.runtime.{Context, RequestHandler}
import org.apache.logging.log4j.{LogManager, Logger}

import scala.collection.JavaConverters
import scala.jdk.CollectionConverters._

This comment has been minimized.

Copy link
@NomadBlacky
@exoego
exoego approved these changes Jun 8, 2019
Copy link
Contributor

left a comment

LGTM 💯

@exoego exoego merged commit eb98a70 into serverless:master Jun 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@medikoo medikoo added this to the 1.45.0 milestone Jun 11, 2019

@medikoo medikoo added the bug label Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.