Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference custom ApiGateway for models and request validators if conf… #6231

Merged

Conversation

@DASPRiD
Copy link
Contributor

commented Jun 11, 2019

When using request parameter/body validation, both the Model and the RequestValidator were always referencing the standard RestApiLogicalId, even if a custom one (from e.g. another stack) were defined. This leads to this feature breaking when using a shared RestApi.

This PR fixes this by using the same method to reference the custom defined RestApiId as the Method itself does.

(This issue is currently blocking deployment for us, it would be terrific if this could be reviewed/published in a short timeframe).

@pmuens pmuens added this to In progress in Serverless via automation Jun 17, 2019

@pmuens pmuens added this to the 1.46.0 milestone Jun 17, 2019

@pmuens pmuens self-assigned this Jun 17, 2019

@pmuens
pmuens approved these changes Jun 17, 2019
Copy link
Member

left a comment

Hey @DASPRiD thanks for fixing this 💯!

I just tested it and it works great 👍

LGTM :shipit:

Serverless automation moved this from In progress to Reviewer approved Jun 17, 2019

@pmuens pmuens merged commit ca830fd into serverless:master Jun 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from Reviewer approved to Done Jun 17, 2019

@DASPRiD DASPRiD deleted the DASPRiD:bugfix/request-model-api-gateway-reference branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.