Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-1091 - message in `npm i` output about the `serverless` quickstart command #6238

Merged
merged 3 commits into from Jul 10, 2019

Conversation

Projects
3 participants
@dschep
Copy link
Member

commented Jun 12, 2019

What did you implement:

Closes PLAT-1091

DO NOT MERGE until @medikoo implements the sls quickstart

How did you implement it:

added console log to the existing postinstall script

How can we verify it:

npm i -g git://github.com/serverless/serverless.git#serveless-command-ad

Todos:

  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@dschep dschep added the cat/dx label Jun 12, 2019

@pmuens pmuens changed the title PLAT-1091 - message in `npm i` output about the `serverless` qucikstart command PLAT-1091 - message in `npm i` output about the `serverless` quickstart command Jun 17, 2019

@pmuens
Copy link
Member

left a comment

Just tested it and it worked 👍

Apparently there are still some linting issues which need to be fixed.

@pmuens pmuens added this to In progress in Serverless via automation Jun 26, 2019

@pmuens pmuens added this to the 1.47.0 milestone Jun 26, 2019

@pmuens
Copy link
Member

left a comment

FYI: Just merged master into this PR and fixed the linting errors.

@pmuens

pmuens approved these changes Jun 27, 2019

Serverless automation moved this from In progress to Reviewer approved Jun 27, 2019

@dschep dschep changed the title PLAT-1091 - message in `npm i` output about the `serverless` quickstart command DO NOT MERGE - PLAT-1091 - message in `npm i` output about the `serverless` quickstart command Jun 27, 2019

@pmuens pmuens added pr/in-review and removed pr/in-progress labels Jul 10, 2019

@pmuens

pmuens approved these changes Jul 10, 2019

@pmuens pmuens changed the title DO NOT MERGE - PLAT-1091 - message in `npm i` output about the `serverless` quickstart command PLAT-1091 - message in `npm i` output about the `serverless` quickstart command Jul 10, 2019

@medikoo medikoo merged commit cef6828 into master Jul 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jul 10, 2019

@medikoo medikoo deleted the serveless-command-ad branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.