Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo #6301

Merged
merged 4 commits into from Jun 26, 2019

Conversation

Projects
3 participants
@garethmcc
Copy link

commented Jun 26, 2019

What did you implement:

Corrected a typo in the documentation

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo
Copy link
Member

left a comment

Thanks @garethmcc Fixing typo looks good, still rewritten links looks broken in places (was that intentional change?)

Side note: I think you need to configure email you use for commits on GitHub, as you're commits are not paired with your GitHub account

- [API Gateway](#API-Gateway)
- [Lambda Proxy Integration](#Lambda-Proxy-Integration)
- [Simple HTTP Endpoint](#Simple-HTTP-Endpoint)
- [Example "LAMBDA-PROXY" event (default)](#Example-%22LAMBDA-PROXY%22-event-default)

This comment has been minimized.

Copy link
@medikoo

medikoo Jun 26, 2019

Member

I just checked, and this breaks link on GitHub, while currently it works on both GitHub on Website https://serverless.com/framework/docs/providers/aws/events/apigateway/#example-lambda-proxy-event-default

Are those link changes intended?

@garethmcc

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

Those link changes were not intended. Not sure why it did that after merging master. I only edited one character on one line.

@garethmcc

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

Can we cancel the PR I'll do it again

@medikoo

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Can we cancel the PR I'll do it again

Yes, no problem!

@pmuens pmuens added this to In progress in Serverless via automation Jun 26, 2019

@pmuens pmuens added this to the 1.47.0 milestone Jun 26, 2019

@pmuens

pmuens approved these changes Jun 26, 2019

Copy link
Member

left a comment

Hey @garethmcc I just merged master into this PR and fixed the incorrect formatting.

I assume this change is what you were looking for. Let us know if it's GTM and we can merge it right away.

@pmuens pmuens requested a review from medikoo Jun 26, 2019

Serverless automation moved this from In progress to Reviewer approved Jun 26, 2019

@pmuens pmuens self-assigned this Jun 26, 2019

@pmuens

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

I only edited one character on one line.

I think that's the answer we're looking for. So it should be GTM :shipit:

@pmuens pmuens merged commit 66c5625 into master Jun 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jun 26, 2019

@pmuens pmuens deleted the correct-typo branch Jun 26, 2019

@pmuens pmuens referenced this pull request Jun 26, 2019

Closed

Corrected typo #6307

0 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.