Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix service.provider.region resolution #6317
Fixes regression introduced with #6200
After which resolution of
Additionally improved setup of integration package tests:
Having that, added test that covers this case
Is this ready for review?: YES
referenced this pull request
Jun 28, 2019
pmuens left a comment •
I just tested it and it works, so it's GTM
TBH I'm on the fence here. Usually it should be
We can merge it, but it's quite inconsistent.
Yes I agree. Indeed documentation clearly states that: https://serverless.com/framework/docs/providers/aws/guide/variables#reference-properties-in-serverlessyml
But it also means that internally we play not clean. As it's not the only property which we add to
It appears some users for a long time relied on this side effects, and I thought it might be a good call to not change that with non breaking release. What do you think?
And in one of the next majors (or breaking release) I think we should switch to some more consistent handling.
I think best would be if we expose some uniform serverless/service object that's also advertised as single source of true (so users wouldn't have to do