Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Webpack version and usage of aws-nodejs-ecma-script template #6324

Merged
merged 3 commits into from Jul 2, 2019

Conversation

Projects
2 participants
@nahumzs
Copy link
Contributor

commented Jun 29, 2019

The current config will not work in the newest webpack version

What did you implement:

Closes #XXXXX

Using currently webpack.config.js will not work in the recent webpack version, you will get the following error when running invoke:

Screen Shot 2019-06-29 at 2 19 12 PM

With the new config:
Screen Shot 2019-06-29 at 2 19 32 PM

How did you implement it:

Just updating the webpack config file.

How can we verify it:

Install this template and run
sls invoke local -f first with the current config will fail, with the webpack.config.js that I'm proposing will succeed.

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO sure

Not sure how to write tests for this template.

updating webpack file
The current config will not work in the newest webpack version
@pmuens
Copy link
Member

left a comment

Hey @nahumzs thanks for working on this 👍

It seems like Prettier failed. Can you run Prettier to ensure that we have a consistent code formatting?
Let us know if you need any help with that.

pmuens added some commits Jul 2, 2019

@pmuens pmuens changed the title aws-nodejs-ecma-script updating webpack.config.js file Update Webpack version and usage of aws-nodejs-ecma-script template Jul 2, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jul 2, 2019

@pmuens pmuens added this to the 1.47.0 milestone Jul 2, 2019

@pmuens

pmuens approved these changes Jul 2, 2019

Copy link
Member

left a comment

I just updated the PR with some fixes and can confirm that those changes made it possible for the template to work with newer Webpack versions.

Thanks for getting this started @nahumzs 👍

LGTM :shipit:

Serverless automation moved this from In progress to Reviewer approved Jul 2, 2019

@pmuens pmuens merged commit aa72173 into serverless:master Jul 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.