Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in AWS ALB event documentation #6325

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
2 participants
@richardowen
Copy link
Contributor

commented Jul 1, 2019

What did you implement:

Fixed documentation typo

How did you implement it:

How can we verify it:

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens self-assigned this Jul 1, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jul 1, 2019

@pmuens pmuens added this to the 1.47.0 milestone Jul 1, 2019

Serverless automation moved this from In progress to Reviewer approved Jul 1, 2019

@pmuens

pmuens approved these changes Jul 1, 2019

Copy link
Member

left a comment

Thanks @richardowen 👍

@pmuens pmuens merged commit 62709f7 into serverless:master Jul 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.