Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Travis CI conf #6330

Merged
merged 10 commits into from Jul 4, 2019

Conversation

Projects
2 participants
@medikoo
Copy link
Member

commented Jul 3, 2019

  • Ensure that latest versions of dependencies are installed for each build
  • Configure cache (reduces install time from ca 30s to 5s)
  • Instead of joining scripts with &&, configure Travis bash with set -e. Improves configuration readability and makes Travis behave up to expectations (fail build on first script fail)
  • Ensure to fail builds if deployment fails
  • Reduplicate env vars configuration (by configuring common global group via env.global)
  • Improve inline comments

Is this ready for review?: YES
Is it a breaking change?: NO

medikoo added some commits Jul 3, 2019

@medikoo medikoo self-assigned this Jul 3, 2019

@medikoo medikoo added pr/in-review and removed pr/in-progress labels Jul 3, 2019

@medikoo medikoo requested a review from pmuens Jul 3, 2019

@pmuens pmuens added this to In progress in Serverless via automation Jul 3, 2019

@pmuens pmuens added this to the 1.47.0 milestone Jul 3, 2019

Serverless automation moved this from In progress to Reviewer approved Jul 3, 2019

@pmuens
Copy link
Member

left a comment

LGTM :shipit:

Serverless automation moved this from Reviewer approved to Needs review Jul 3, 2019

@medikoo medikoo force-pushed the improve-travis-conf branch from 8b3b743 to 58f6cc2 Jul 3, 2019

@medikoo medikoo force-pushed the improve-travis-conf branch 2 times, most recently from 50803db to 3f2df69 Jul 3, 2019

@medikoo medikoo added pr/in-progress and removed pr/in-review labels Jul 4, 2019

@medikoo medikoo force-pushed the improve-travis-conf branch from 3f2df69 to 9d158fb Jul 4, 2019

medikoo added some commits Jul 4, 2019

@medikoo medikoo force-pushed the improve-travis-conf branch from 9d158fb to 28b9f43 Jul 4, 2019

medikoo added some commits Jul 4, 2019

@medikoo medikoo force-pushed the improve-travis-conf branch from 28b9f43 to 4d3afe2 Jul 4, 2019

@medikoo medikoo changed the title Cleanup Travis CI conf Improve Travis CI conf Jul 4, 2019

@medikoo medikoo added pr/in-review and removed pr/in-progress labels Jul 4, 2019

@medikoo

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@pmuens sorry for confusion, when you approved I realized there are few more worthy improvements to include (figured them out, when improving config for @serverless/enterprise-plugin).

I updated description with what it covers, and Travis config is also well commented.

Can you re-review?

@medikoo medikoo requested a review from pmuens Jul 4, 2019

Serverless automation moved this from Needs review to Reviewer approved Jul 4, 2019

@pmuens

pmuens approved these changes Jul 4, 2019

Copy link
Member

left a comment

Just read through the Travis CI docs on caching and it seems to be a good way to speed things up!

Thanks for working on this @medikoo 👍

LGTM :shipit:

@medikoo medikoo merged commit 1fe3abb into master Jul 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.