Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async S3 test #6385

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@pmuens
Copy link
Member

commented Jul 16, 2019

What did you implement:

Fixes a test where an async function was not returned.

How did you implement it:

Return the async function.

How can we verify it:

See that the unit tests are working fine.

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • x ] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added this to the 1.48.0 milestone Jul 16, 2019
@pmuens pmuens requested a review from medikoo Jul 16, 2019
@pmuens pmuens self-assigned this Jul 16, 2019
@pmuens pmuens added this to In progress in Serverless via automation Jul 16, 2019
Serverless automation moved this from In progress to Reviewer approved Jul 16, 2019
@pmuens pmuens merged commit 4e70ab5 into master Jul 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (serverless) No manifest changes detected
Serverless automation moved this from Reviewer approved to Done Jul 16, 2019
@pmuens pmuens deleted the fix-s3-test branch Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Serverless
  
Done
2 participants
You can’t perform that action at this time.