Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain existing Cognito User Pool config #6519

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@pmuens
Copy link
Member

commented Aug 8, 2019

What did you implement:

Closes #6499

Ensures that the existing Cognito User Pool Config is retained.

How did you implement it:

Fetch the current config and re-apply it to the params when updating the Cognito User Pool with the desired Trigger config.

How can we verify it:

  1. Create a new User Pool
  2. Add a tag
  3. Deploy the following serverless.yml service

The Trigger config should be updated. The tag should not be removed.

Otherwise you can also run the integration tests.

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added this to the 1.50.0 milestone Aug 8, 2019
@pmuens pmuens self-assigned this Aug 8, 2019
@pmuens pmuens added this to Engineering - In Development in Serverless via automation Aug 8, 2019
@pmuens pmuens force-pushed the retain-cognito-user-pool-config branch from 2efae60 to cd81b2e Aug 8, 2019
@pmuens pmuens requested a review from medikoo Aug 8, 2019
@pmuens pmuens force-pushed the retain-cognito-user-pool-config branch from cd81b2e to f2a3fc9 Aug 8, 2019
Serverless automation moved this from Engineering - In Development to Reviewer Approved Aug 8, 2019
@medikoo
medikoo approved these changes Aug 8, 2019
Copy link
Member

left a comment

Looks good!

Copy link

left a comment

LGTM 👍

@pmuens pmuens merged commit 42ba297 into master Aug 9, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (serverless) No manifest changes detected
Serverless automation moved this from Reviewer Approved to Done Aug 9, 2019
@pmuens pmuens deleted the retain-cognito-user-pool-config branch Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Serverless
  
Done
3 participants
You can’t perform that action at this time.