Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retained layer logical id #6545

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@mokamoto12
Copy link
Contributor

commented Aug 14, 2019

What did you implement:

Closes #6532

How did you implement it:

compute layer logical id's suffix sha without S3Key

How can we verify it:

Set layers to be retained and invokes full stack deployments, sls deploy, twice.
The second one is skipped!

  • serverless.yml
layers:
  common:
    path: layers
    name: ${self:custom.stage}-common
    compatibleRuntimes:
    - python3.7
    retain: true
  • Screenshots

スクリーンショット 2019-08-14 23 47 01

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Member

left a comment

Thank you @mokamoto12, looks great! Taking it in

@medikoo medikoo merged commit b2091b0 into serverless:master Aug 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (serverless) No manifest changes detected
@medikoo medikoo added the bug label Aug 16, 2019
@medikoo medikoo added this to Engineering - In Development in Serverless via automation Aug 16, 2019
@medikoo medikoo added this to the 1.51.0 milestone Aug 16, 2019
@pmuens pmuens moved this from Engineering - In Development to Done in Serverless Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Serverless
  
Done
2 participants
You can’t perform that action at this time.