Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS Limits on Lambda@Edge #6922

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@winstonwp
Copy link
Contributor

winstonwp commented Nov 4, 2019

What did you implement

Updated AWS Limits on Lambda@Edge

Closes #6913

How can we verify it

originResponseFunction:
    handler: originResponseFunction/index.handler
    timeout: 30
    memorySize: 896
    role: LambdaAtEdgeRole
    events:
      - cloudFront:
          eventType: origin-response
          origin: nameOfOrigin
  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added this to Engineering - In Development in Serverless via automation Nov 5, 2019
@pmuens pmuens added this to the 1.57.0 milestone Nov 5, 2019
@pmuens
pmuens approved these changes Nov 5, 2019
Copy link
Member

pmuens left a comment

Thanks for fixing this @winstonwp 👍

I just tested it and it works as expected! LGTM :shipit:

Serverless automation moved this from Engineering - In Development to Reviewer Approved Nov 5, 2019
@pmuens pmuens merged commit 3631ed1 into serverless:master Nov 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (serverless) No manifest changes detected
Serverless automation moved this from Reviewer Approved to Done Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Serverless
  
Done
2 participants
You can’t perform that action at this time.